Skip to content

Fix test browser configuring. #25258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 11, 2025
Merged

Fix test browser configuring. #25258

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions test/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2476,17 +2476,16 @@ def configure_test_browser():
if not has_browser():
return

if not EMTEST_BROWSER:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems odd that this code even runs at all then a non-browser test suite runs

EMTEST_BROWSER = 'google-chrome'

if WINDOWS and '"' not in EMTEST_BROWSER and "'" not in EMTEST_BROWSER:
# On Windows env. vars canonically use backslashes as directory delimiters, e.g.
# set EMTEST_BROWSER=C:\Program Files\Mozilla Firefox\firefox.exe
# and spaces are not escaped. But make sure to also support args, e.g.
# set EMTEST_BROWSER="C:\Users\clb\AppData\Local\Google\Chrome SxS\Application\chrome.exe" --enable-unsafe-webgpu
EMTEST_BROWSER = '"' + EMTEST_BROWSER.replace("\\", "\\\\") + '"'

if not EMTEST_BROWSER:
logger.info('No EMTEST_BROWSER set. Defaulting to `google-chrome`')
EMTEST_BROWSER = 'google-chrome'

if EMTEST_BROWSER_AUTO_CONFIG:
config = None
if is_chrome():
Expand Down