Skip to content

Fix get_native_triple() on Windows-on-ARM devices. #25283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 15, 2025
Merged

Fix get_native_triple() on Windows-on-ARM devices. #25283

merged 1 commit into from
Sep 15, 2025

Conversation

juj
Copy link
Collaborator

@juj juj commented Sep 15, 2025

Fixes

other.test_bad_triple
other.test_dot_a_all_contents_invalid
other.test_native_link_error_message

on Windows-on-ARM.

sbc100
sbc100 reviewed Sep 15, 2025
View reviewed changes
test/clang_native.py
'ARM64': 'arm64', # Python on Windows-on-ARM reports uppercase ARM64
'x86_64': 'x86_64',
'AMD64': 'x86_64',
}[platform.machine()]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about platform.machine().lower() here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considered it, but I'd rather see more cases of this from Python before going there.

sbc100
sbc100 approved these changes Sep 15, 2025
View reviewed changes
Copy link
Collaborator

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm either way

@juj juj enabled auto-merge (squash) September 15, 2025 20:06
@juj juj merged commit 7486c5c into emscripten-core:main Sep 15, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbc100 sbc100 sbc100 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juj @sbc100