Skip to content

Fix get_native_triple() on Windows-on-ARM devices. #25283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 15, 2025
Merged

Fix get_native_triple() on Windows-on-ARM devices. #25283

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion test/clang_native.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,8 @@ def get_native_triple():

arch = {
'aarch64': 'arm64',
'arm64': 'arm64',
'arm64': 'arm64', # Python on Apple Silicon ARM64 reports lowercase arm64
'ARM64': 'arm64', # Python on Windows-on-ARM reports uppercase ARM64
'x86_64': 'x86_64',
'AMD64': 'x86_64',
}[platform.machine()]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about platform.machine().lower() here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considered it, but I'd rather see more cases of this from Python before going there.

Expand Down