Skip to content

Commit dddf66f

Browse files
committed
[OCaml] Rename link_modules' to link_modules
Commit 434e956 renamed link_modules to link_modules' for unclear reasons. Based on the commit's diff, the author possibly intended to have two functions, link_modules to bind to LLVMLinkModules and link_modules' to bind to LLVMLinkModules2. However, there is only one function. link_modules' appears in LLVM 3.8 onwards. Differential Revision: https://reviews.llvm.org/D153090
1 parent b472176 commit dddf66f

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

llvm/bindings/ocaml/linker/llvm_linker.ml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,5 +10,5 @@ exception Error of string
1010

1111
let () = Callback.register_exception "Llvm_linker.Error" (Error "")
1212

13-
external link_modules' : Llvm.llmodule -> Llvm.llmodule -> unit
14-
= "llvm_link_modules"
13+
external link_modules : Llvm.llmodule -> Llvm.llmodule -> unit
14+
= "llvm_link_modules"

llvm/bindings/ocaml/linker/llvm_linker.mli

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,6 @@
1313

1414
exception Error of string
1515

16-
(** [link_modules' dst src] links [src] into [dst], raising [Error]
16+
(** [link_modules dst src] links [src] into [dst], raising [Error]
1717
if the linking fails. The src module is destroyed. *)
18-
val link_modules' : Llvm.llmodule -> Llvm.llmodule -> unit
18+
val link_modules : Llvm.llmodule -> Llvm.llmodule -> unit

llvm/test/Bindings/OCaml/linker.ml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,18 +43,18 @@ let test_linker () =
4343

4444
let m1 = make_module "one"
4545
and m2 = make_module "two" in
46-
link_modules' m1 m2;
46+
link_modules m1 m2;
4747
dispose_module m1;
4848

4949
let m1 = make_module "one"
5050
and m2 = make_module "two" in
51-
link_modules' m1 m2;
51+
link_modules m1 m2;
5252
dispose_module m1;
5353

5454
let m1 = make_module "one"
5555
and m2 = make_module "one" in
5656
try
57-
link_modules' m1 m2;
57+
link_modules m1 m2;
5858
failwith "must raise"
5959
with Error _ ->
6060
dispose_module m1

0 commit comments

Comments
 (0)