[flang] Suppress a warning in D118631 [-Wunused-result]

Shao-Ce SUN · Shao-Ce SUN · commit f95bdff17b3e · 2023-02-01T00:30:10.000+08:00
Reviewed By: klausler Differential Revision: https://reviews.llvm.org/D142965
diff --git a/flang/lib/Semantics/mod-file.cpp b/flang/lib/Semantics/mod-file.cpp
@@ -963,8 +963,10 @@ Scope *ModFileReader::Read(const SourceName &name,
     // directory lists, the intrinsic module directory takes precedence.
     options.searchDirectories = context_.searchDirectories();
     for (const auto &dir : context_.intrinsicModuleDirectories()) {
-      std::remove(options.searchDirectories.begin(),
-          options.searchDirectories.end(), dir);
+      options.searchDirectories.erase(
+          std::remove(options.searchDirectories.begin(),
+              options.searchDirectories.end(), dir),
+          options.searchDirectories.end());
     }
     options.searchDirectories.insert(options.searchDirectories.begin(), "."s);
   }

Original file line number	Diff line number	Diff line change
`@@ -963,8 +963,10 @@ Scope *ModFileReader::Read(const SourceName &name,`
`963`	`963`	`// directory lists, the intrinsic module directory takes precedence.`
`964`	`964`	`options.searchDirectories = context_.searchDirectories();`
`965`	`965`	`for (const auto &dir : context_.intrinsicModuleDirectories()) {`
`966`		`- std::remove(options.searchDirectories.begin(),`
`967`		`- options.searchDirectories.end(), dir);`
	`966`	`+ options.searchDirectories.erase(`
	`967`	`+ std::remove(options.searchDirectories.begin(),`
	`968`	`+ options.searchDirectories.end(), dir),`
	`969`	`+ options.searchDirectories.end());`
`968`	`970`	`}`
`969`	`971`	`options.searchDirectories.insert(options.searchDirectories.begin(), "."s);`
`970`	`972`	`}`