Fix issue 105 for EigenvalueDecomposition #110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffheaton
added a commit
that referenced
this pull request
May 29, 2012
…ition Fix issue 105 for EigenvalueDecomposition
Owner
|
Thanks, looks okay, and I will review further. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimizes the
EigenvalueDecompositionclass and adds a new test. The optimizations are mostly either usingSystem.arraycopy()orArrays.fill()instead of doing the same manually. However I also changed the code that detects symmetric matrices to be more efficient by only doing one compare for most positions and doing no compares for the diagonal.I am not an expert at all of the math involved in this class, so I would appreciate it if someone could carefully review this change to make sure I'm not messing something up.