Replace panic! with Option in to_obj_section_kind
#25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this simplifies the code a little and reduces the likelihood of introducing a panic in the future. Maybe in the future we would want to log something if we see an unsupported section.
Btw, I'm curious why so much work is done to convert object::* types to various obj::Obj* types? Are there some features of the object crate that are incompatible with objdiff's goals?