Skip to content

Commit 85c31b3

Browse files
committed
WIP
1 parent 3622c47 commit 85c31b3

4 files changed

Lines changed: 9 additions & 7 deletions

File tree

Sources/xcparse/AttachmentsCommand.swift

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
import Foundation
1010
import TSCBasic
1111
import TSCUtility
12+
import CoreFoundation
1213

1314
struct AttachmentsCommand: Command {
1415
let command = "attachments"
@@ -88,11 +89,11 @@ struct AttachmentsCommand: Command {
8889
divideByTest: arguments.get(self.divideByTest) ?? false)
8990
if let allowedUTIsToExport = arguments.get(self.utiWhitelist) {
9091
options.attachmentFilter = {
91-
let attachmentUTI = $0.uniformTypeIdentifier as CFString
92+
let attachmentUTI = $0.uniformTypeIdentifier as! CFString
9293
for allowedUTI in allowedUTIsToExport {
93-
if UTTypeConformsTo(attachmentUTI, allowedUTI as CFString) {
94+
//if UTTypeConformsTo(attachmentUTI, allowedUTI as CFString) {
9495
return true
95-
}
96+
//}
9697
}
9798
return false
9899
}

Sources/xcparse/CommandRegistry.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -69,8 +69,8 @@ struct CommandRegistry {
6969
divideByTargetOS: false,
7070
divideByTestPlanConfig: false,
7171
xcresulttoolCompatability: xcresulttoolCompatability,
72-
attachmentFilter: {
73-
return UTTypeConformsTo($0.uniformTypeIdentifier as CFString, "public.image" as CFString)
72+
attachmentFilter: { _ in
73+
return true //UTTypeConformsTo($0.uniformTypeIdentifier as CFString, "public.image" as CFString)
7474
})
7575
try xcpParser.extractAttachments(xcresultPath: legacyScreenshotPaths[0].path.pathString,
7676
destination: destination,

Sources/xcparse/ScreenshotsCommand.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,8 +88,8 @@ struct ScreenshotsCommand: Command {
8888
divideByLanguage: arguments.get(self.divideByLanguage) ?? false,
8989
divideByRegion: arguments.get(self.divideByRegion) ?? false,
9090
divideByTest: arguments.get(self.divideByTest) ?? false,
91-
attachmentFilter: {
92-
return UTTypeConformsTo($0.uniformTypeIdentifier as CFString, "public.image" as CFString)
91+
attachmentFilter: { _ in
92+
return true //UTTypeConformsTo($0.uniformTypeIdentifier as CFString, "public.image" as CFString)
9393
})
9494
if let allowedTestStatuses = arguments.get(self.testStatusWhitelist) {
9595
options.testSummaryFilter = { allowedTestStatuses.contains($0.testStatus) }

Sources/xcparse/XCPParser.swift

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ import TSCBasic
1111
import TSCUtility
1212
import XCParseCore
1313
import Converter
14+
import FoundationNetworking
1415

1516
let xcparseCurrentVersion = Version(2, 2, 1)
1617

0 commit comments

Comments
 (0)