Show Block Code editor when BlockCode node is selected #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, when a node is selected, Godot shows the 2D or 3D editor corresponding to the selected node type. Showing the Block Code editor when a BlockCode node is selected will make the flow of the editor easier to understand.
dbnicholson
approved these changes
Jun 17, 2024
Member
dbnicholson
left a comment
dbnicholson
left a comment
There was a problem hiding this comment.
👏 My godot knowledge is not high enough to know if this is the correct way to do it, but it certainly looks reasonable.
|
|
||
|
|
||
| func _on_editor_inspector_edited_object_changed(): | ||
| var block_code: BlockCode = editor_inspector.get_edited_object() as BlockCode |
Member
There was a problem hiding this comment.
I was not aware of Godot's behavior to set the casted value to null if doesn't match the casted type. That's both neat and frightening.
Contributor
|
This is great @dylanmccall ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, when a node is selected, Godot shows the 2D or 3D editor corresponding to the selected node type. Showing the Block Code editor when a BlockCode node is selected will make the flow of the editor easier to understand.