Add a "Send signal to node" block #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This is really good! I also thought having this block would be useful when I was making the pong game. Signals aren't currently working pending a fix in the pong game PR which I hopefully will get merged shortly. |
dylanmccall
force-pushed
the
add-send-signal-to-node
branch
from
d029c1b to
34335fd
Compare
wnbaum
approved these changes
Jun 21, 2024
Contributor
wnbaum
left a comment
wnbaum
left a comment
There was a problem hiding this comment.
Still working great! Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #60, I wasn't a fan of us needing to reset all of the ball nodes when a player scores, so I'm proposing a "send signal to node" block. This requires a little bit of tweaking so we aren't defining
var signal_managerin either of the send signal blocks, which makes it possible to include multiple of them in the same context.