Re-order blocks when a block is placed in an occupied snap point #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylanmccall
force-pushed
the
T35519-snap-point-enhancements
branch
from
8354a46 to
ebcd851
Compare
wnbaum
approved these changes
Jun 22, 2024
Contributor
wnbaum
left a comment
wnbaum
left a comment
There was a problem hiding this comment.
So great!! Thanks for doing this. Working exactly how I imagined it and you implemented it very neatly.
| preview_block.custom_minimum_size = dragging.get_global_rect().size | ||
| preview_block.size_flags_horizontal = Control.SIZE_SHRINK_BEGIN | ||
| preview_block.size_flags_vertical = Control.SIZE_SHRINK_BEGIN | ||
|
|
| func switch_input(node: Node): | ||
| func _update_visible_input(): | ||
| if snap_point.has_snapped_block(): | ||
| _switch_input(null) |
Contributor
There was a problem hiding this comment.
Good, hide any input if we snap something!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://phabricator.endlessm.com/T35519