feat: add support for portable/standalone modules installation for wi… #273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #273 +/- ##
==========================================
- Coverage 99.35% 98.66% -0.69%
==========================================
Files 2 2
Lines 2932 2471 -461
==========================================
- Hits 2913 2438 -475
- Misses 19 33 +14
Continue to review full report at Codecov.
|
xdelaruelle
requested changes
May 14, 2019
Collaborator
xdelaruelle
left a comment
xdelaruelle
left a comment
There was a problem hiding this comment.
Very good idea. I would suggest to also define the MODULES_CMD variable and make it contains the fully qualified path of modulecmd.tcl, then update the module.cmd to rely on this variable to call the modulecmd.tcl script.
jraphanel
force-pushed
the
feat-windows-portable-installation
branch
from
ac5cec7 to
d34240c
Compare
Make mb, mlprof, mtreview and playdemo use `/usr/bin/env tclsh` shebang rather applying there TCLSH location defined by `./configure` process.
Update moduleinit.cmd file to set Modules-specific environment variables according to the script directory and the file existence for: * MODULESHOME if not defined yet and if `..\libexec\modulecmd.tcl` exists * add `..\bin` directory to PATH if `module.cmd` is not available from PATH and available from `..\bin` * add `..\bin` directory to PATH if `tclsh.exe` is not available from PATH and available from `..\bin` Automatically call `moduleinit.cmd` from `module.cmd` if modules is not initialized yet (based on environment variables) Fixes envmodules#272
Provide new `--enable-windows-support` option for configure to automatically install windows batch file to bin directory during install step. This new option is not enabled by default.
Always define Modules-specific environment variables when running `cmd` initialization file.
Execute initialization script if MODULES_CMD environment variable is not found defined.
xdelaruelle
force-pushed
the
feat-windows-portable-installation
branch
from
5b85789 to
17f1f50
Compare
xdelaruelle
approved these changes
Jan 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ndows platform
update moduleinit.cmd file to specific environment variables according to the script directory and the file existence for:
Closes #272