Crufty lib cleanup #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecolignon
approved these changes
Jan 21, 2025
Contributor
ecolignon
left a comment
ecolignon
left a comment
There was a problem hiding this comment.
Thanks for the cleanup! Just to verify my understanding:
- We're getting rid of the outdated CI configuration from Travis CI since the gem now uses GHA.
- We're eliminating unnecessary database dependencies that were previously used for database-backed specs, which aren't needed now because everything runs in-memory.
Have we validated that all consumers of this gem, e.g. envoy-web, will continue to function as expected after these changes?
Contributor
Author
No, but thats why I bumped the version 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up this crufty lib.
Trying to upgrade pg gem in envoy-web, this is blocking.