docs: Fix links in each README.md #907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, front-proxy, golang-http, grpc-bridge, jaeger-tracing, load-reporting-service, wasm-cc) Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
ffjlabo
force-pushed
the
fix-docs-link-in-readme
branch
from
f0ca65a to
e6959eb
Compare
Contributor
Author
|
FYI, I found the examples which doesn't follow the generation rule, but I couldn't investigate the reason for now. (This is just a note.)
|
phlax
approved these changes
Nov 3, 2025
Member
i think the solution here is removal - its long since not supported |
Contributor
Author
|
@phlax Thank you for the quick response :)
OK, Is https://github.com/envoyproxy/examples/tree/main/win32-front-proxy the removal thing? |
Member
|
lets remove it in a separate pr/commit - so its explicit (yep - we no longer support/test windows builds) |
Contributor
Author
|
OK, will create another PR for removing it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed links in each README.md to be able to access each sandbox page.
Basically, I fixed them based on the generated html file names in the envoy/archive repo (https://github.com/envoyproxy/archive/tree/main/docs/envoy/v1.36.2/start/sandboxes)
This might be caused by the fixes in envoyproxy/envoy#34429, generating the rst files as
<dirname>.rst.