Skip to content

Conversation

@zyd-n
Copy link

@zyd-n zyd-n commented Sep 26, 2024

This fixes up the display of the inline arglist for Lisp (Slime and Sly) via the C-2 keybinding. Before, symbols would be very cluttered with unnecessary package prefixes and were not aware of package local nicknames. You would also get an error if you tried to get the arglist for a macro. Tested on both Sly and Slime but the patch probably needs some style review as I don't write a ton of elisp.

Before:
2024-09-25__04:06:50

After:
2024-09-25__04:07:18

Here is a package local nickname defined in my current package being successfully displayed:
2024-09-25__10:33:59

And here is a package local nickname but it's a nickname not defined in my package but a different home package:
2024-09-25__10:34:38

@enzuru
Copy link
Owner

enzuru commented Sep 30, 2024

Looks good, I'll cleanup style in a followup commit.

@enzuru enzuru merged commit 7b8476d into enzuru:master Sep 30, 2024
@enzuru
Copy link
Owner

enzuru commented Sep 30, 2024

Sorry, I think I merged this too soon. I began to run into a bug with C-2:

"upcase: Wrong type argument: stringp, nil [9 times]"

Reverted for now.

@zyd-n
Copy link
Author

zyd-n commented Sep 30, 2024

@enzuru

Sorry, I think I merged this too soon. I began to run into a bug with C-2:

"upcase: Wrong type argument: stringp, nil [9 times]"

Reverted for now.

Are you getting this in sly or slime? I've been using this patch for a while and haven't seen that yet.

@enzuru
Copy link
Owner

enzuru commented Sep 30, 2024

Sly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants