create markup #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
safonovaA
reviewed
Jul 11, 2019
| font-size: 62.5%; | ||
| } | ||
| body { | ||
| font-size: 1.6rem; |
There was a problem hiding this comment.
Для относительных величин шрифта лучше где-нибудь в body определить дефолтный размер, т.к. в браузерах может отличаться это значение
| } | ||
| .info__temp { | ||
| color: #8d9396; | ||
| font-family: "Proxima Nova"; |
There was a problem hiding this comment.
Для шрифтов лучше указать фолбековый шрифт, если основной шрифт не подтянется.Например, почитать можно здесь: https://css-tricks.com/css-basics-fallback-font-stacks-robust-web-typography/
| <div class="card__top"> | ||
| <a><img src="img/refresh.png" alt="refresh" class="card__refresh"/></a> | ||
| <img src="img/refresh.png" alt="refresh" class="card__refresh" /> | ||
| <img src="img/cloudy.png" alt="cloudy" class="card__img" /> |
There was a problem hiding this comment.
Очень приятно видеть альты для картинок :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.