Cubes. Anastasiya Santalova #11
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnastasiyaSantalova
changed the title
svvald
approved these changes
Jul 22, 2019
svvald
left a comment
svvald
left a comment
There was a problem hiding this comment.
Great work overall with a couple of minor remarks.
Anastasiya Santalova/hw1.css
Outdated
| height: 100%; | ||
| } | ||
|
|
||
| .weather__background_transparency { |
There was a problem hiding this comment.
I'd call it transparent since modifier name is rather adjective than noun like invisible above.
Author
There was a problem hiding this comment.
Yes, you right. Fixed :)
|
|
||
| <div class="weather weather-skyblue"> | ||
|
|
||
| <div class="weather__block_visible"> |
There was a problem hiding this comment.
You have a lot of div and span elements that are not semantic. It's not critical but sometimes it's better to use semantic tags like header, main, section, footer etc.
Author
There was a problem hiding this comment.
My widget has no header and footer, but I've changed some tags. Thank you for comments!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test pictures were used. Cross-browser compatibility was not verified.