Разметка и немного стилей #12
Conversation
Nikita Korzhavin/cubes.css
Outdated
| } | ||
|
|
||
| body { | ||
| font-family: 'AvenirNext-Bold'; |
There was a problem hiding this comment.
You should always use some default fallback font or fonts since in some cases your additional fonts could be unavailable.
There was a problem hiding this comment.
i edited homework according comments
i just pushed them, so you can see changed files
Or should i make a new pull request or ...?
There was a problem hiding this comment.
Pull request automatically reflects all the changes you push so there is no need to create new pull request
Nikita Korzhavin/cubes.css
Outdated
| width: 800px; | ||
| } | ||
|
|
||
| .bg2 { |
There was a problem hiding this comment.
I don't really like this and previous classnames, I'd make them more meaningful.
| height: 600px; | ||
| width: 800px; | ||
|
|
||
| display: -webkit-box; |
There was a problem hiding this comment.
Strange delimiters between rules. I'd group some of them together, e.g. rule and its vendor-specific variants.
Also, it is better to place default rule at first and then list its prefixed options.
Nikita Korzhavin/index.html
Outdated
| <body> | ||
| <div class="bg1"> | ||
| <div class="bg2"> | ||
| <article class="widget"> |
There was a problem hiding this comment.
You used semantic tag once but why didn't you continue do it through all the file?
Also I don't think that article is an appropriate tag for this widget.
There was a problem hiding this comment.
I thought article is for situations when content can be cut from the page without loosing meaning. i thought it's such а situation
What tag fits here best?
There was a problem hiding this comment.
Well, article fits better for some independent text content that could be repeat but is not obliged to be presented on the page like blog post or comment. In your case widget is the essential part of the page. I guess that main tag will be better
Nikita Korzhavin/cubes.css
Outdated
| margin-top: 26px; | ||
| } | ||
|
|
||
| .card__1 { |
There was a problem hiding this comment.
These are meaningless classnames. You could name them like card__blue etc. based on the color.
2 participants
28.06.2019
дз по верстке ч.1
03.06.2019
дз по верстке ч.2