The first task "HTML + CSS" #14
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bye
reviewed
Jul 12, 2019
bye
reviewed
Jul 12, 2019
makarov ivan/site_grid.html
Outdated
| </style> | ||
| </head> | ||
| <body> | ||
| <div class=container> |
Collaborator
There was a problem hiding this comment.
You'd better using not only div but other semantics tags. Here, for example, I would use the tag main
bye
reviewed
Jul 12, 2019
makarov ivan/site_grid.html
Outdated
| width: 581px; | ||
| height: 438px; | ||
| margin: auto; /*главный див будет по центру*/ | ||
| display: grid; |
Collaborator
There was a problem hiding this comment.
I really like your approach with grid layout. Also, I like that the widget looks great in all browsers
bye
reviewed
Jul 12, 2019
makarov ivan/site_grid.html
Outdated
| <body> | ||
| <div class=container> | ||
| <div class=picture_of_sun><p></p></div> | ||
| <div class="word_sunny"><span>Sunny</span></div> |
Collaborator
There was a problem hiding this comment.
Try to use more abstract names for classes here and below. For example, in this case, you could've used weather-condition.
Collaborator
|
Much better, thanks for your work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First task is complited.