cubes #17
cubes #17
Conversation
|
|
||
| <body> | ||
|
|
||
| <div class="all"> |
There was a problem hiding this comment.
You should use more appropriate class name, in this case I would use cubes or container at least
Same for all other classes, instead of using c1 it could be cubes__first-block
| <div class="all"> | ||
| <div class="cube c1"> | ||
| <img src="img/rain.png"> | ||
| <p>CHICAGO/23°</p> |
There was a problem hiding this comment.
It's not necessary to write text in uppercase, consider using styles for that instead
| <p>CHICAGO/23°</p> | ||
| </div> | ||
| <div class="cube c2"> | ||
| <img src="img/fog.png"> |
There was a problem hiding this comment.
You should always add alt attribute for the images, either empty or whats on the picture in two words
| <div class="cube c5"> | ||
| <img src="img/cloud_wind.png"> | ||
| <div class="red_bottom"> | ||
| <div class="day_weather"> |
There was a problem hiding this comment.
You have a lot of similar html tags, <ul> with <li> elements would fit better in this case
Also I would suggest to use more semantic tags
| margin: 5px; | ||
| } | ||
|
|
||
| .day img { |
There was a problem hiding this comment.
avoid using html tags, it's better to use class names, except for body and html
| .all { | ||
| display: flex; | ||
| flex-wrap: wrap; | ||
| color: white; |
There was a problem hiding this comment.
Keep in mind order of properties, group them by type
1 - layout (position, display)
2 - anything related to box model (width/height/margin/padding)
3 - styling for element (color, background, box-shadow)
4 - anything related to font
5 - other stuff, it also includes overflow, z-index
|
|
||
| .day img { | ||
| width: 24px; | ||
| .day {} No newline at end of file |
2 participants
No description provided.