task 1 #6
task 1 #6
Conversation
|
Не могу сдвинуть надпись Sicklerville, New Jersey ниже:( |
IVAN-MARAKHOVSKII/index.html
Outdated
| <img src="refresh.png" alt="" /> | ||
| </div> | ||
| <div class="wheatherImage"> | ||
| <img src="cloud_icon.png" /> |
There was a problem hiding this comment.
Images should have alt attribute, empty or with the short description
IVAN-MARAKHOVSKII/index.html
Outdated
| > | ||
| </div> | ||
| <div class="dayInfo"> | ||
| <span class="topDayText">MAY</span> |
There was a problem hiding this comment.
It's not necessary to write text in uppercase, consider using styles for that instead
IVAN-MARAKHOVSKII/index.html
Outdated
| </head> | ||
| <body> | ||
| <div class="grid"> | ||
| <div class="wheatherWidget"> |
There was a problem hiding this comment.
It's convenient to write class names in kebab case (hyphen case) or BEM
IVAN-MARAKHOVSKII/index.html
Outdated
| <div class="infoBlock"> | ||
| <img src="tempIcon.png" class="tempIcon" /> | ||
| <div class="infoText"> | ||
| <span class="infoTextTop">Cloudy Skies</span><br /><span |
There was a problem hiding this comment.
Since it's not address, and the first part of the text is related to the weather and another to the location, I'd suggest to avoid using br in such cases, the common use case for br is full address with street / apartment / city etc, also it will become easier to style
IVAN-MARAKHOVSKII/index.html
Outdated
| </div> | ||
| </div> | ||
|
|
||
| <div class="pagination"> |
There was a problem hiding this comment.
You should use more semantic tags
In this case you have list of dots, which can be converted to <ul> with multiple <li> inside
| letter-spacing: 1px; | ||
| color: white; | ||
|
|
||
| margin-left: auto; |
There was a problem hiding this comment.
Try to keep in mind order of properties, group them by type
1 - layout (position, display)
2 - anything related to box model (width/height/margin/padding)
3 - styling for element (color, background, box-shadow)
4 - anything related to font
5 - other stuff, it also includes overflow, z-index
IVAN-MARAKHOVSKII/index.html
Outdated
| </div> | ||
| <div class="humidity"> | ||
| <img src="waterdrop.png" alt="" /> | ||
| <span><b>33</b>%</span> |
There was a problem hiding this comment.
It's convenient to avoid tags like <b> and change appearance of the text through css
IVAN-MARAKHOVSKII/index.html
Outdated
| <img src="cloud_icon.png" /> | ||
| </div> | ||
| <div class="infoBlock"> | ||
| <img src="tempIcon.png" class="tempIcon" /> |
There was a problem hiding this comment.
Please, use plain text instead of image
2 participants
No description provided.