Skip to content

Conversation

@SergK
Copy link
Member

@SergK SergK commented Oct 17, 2025

…rs (#227)

Replace Status().Update() with Status().Patch() to reduce conflicts during sequential git status updates in chain handlers. Patch uses server-side merge semantics, only conflicting when the same field is modified concurrently.

Changes:

  • Add updateGitStatusWithPatch helper function with idempotency check
  • Update PutProject, PutGitLabCIConfig, PutDeployConfigs handlers
  • Add comprehensive unit tests for sequential update scenarios

Pull Request Template

Description

Please include a summary of the change and why it is needed.

Fixes #227

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (non-breaking change which improves an existing feature or documentation)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)

Checklist:

  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Pull Request contains one commit. I squash my commits.

@SergK SergK requested a review from a team as a code owner October 17, 2025 20:50
…rs (#227)

Replace Status().Update() with Status().Patch() to reduce conflicts during
sequential git status updates in chain handlers. Patch uses server-side merge
semantics, only conflicting when the same field is modified concurrently.

 Changes:
  - Add updateGitStatusWithPatch helper function with idempotency check
  - Update PutProject, PutGitLabCIConfig, PutDeployConfigs handlers
  - Add comprehensive unit tests for sequential update scenarios

Signed-off-by: Sergiy Kulanov <sergiy_kulanov@epam.com>
@SergK SergK force-pushed the refactor-git-status-update branch from 47e7550 to 2403116 Compare October 20, 2025 07:13
@SergK SergK requested a review from zmotso October 20, 2025 10:06
@SergK SergK merged commit a172e1f into master Oct 20, 2025
3 checks passed
@SergK SergK deleted the refactor-git-status-update branch October 20, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve Git Status Update Reliability in Chain Handlers

3 participants