Skip to content

Conversation

@btnwtn
Copy link
Contributor

@btnwtn btnwtn commented Jul 24, 2019

useCount isn't mentioned anywhere except this line. Dunno if you wanted to make a useCount hook as extra credit, but as it is now, this is a bit confusing.

@codecov
Copy link

codecov bot commented Jul 24, 2019

Codecov Report

Merging #13 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #13   +/-   ##
=======================================
  Coverage   57.37%   57.37%           
=======================================
  Files          13       13           
  Lines         244      244           
  Branches       13       13           
=======================================
  Hits          140      140           
  Misses         99       99           
  Partials        5        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41146ca...7c70109. Read the comment docs.

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! Yes! Thanks for this fix 👍

@kentcdodds kentcdodds merged commit 37352e8 into epicweb-dev:master Jul 25, 2019
@kentcdodds
Copy link
Member

@all-contributors please add @btnwtn for docs

@allcontributors
Copy link
Contributor

@kentcdodds

I've put up a pull request to add @btnwtn! 🎉

SpencerHaan pushed a commit to SpencerHaan/advanced-react-hooks that referenced this pull request Jan 25, 2022
* docs: update README.md

* docs: update .all-contributorsrc


Co-authored-by: null <46447321+allcontributors[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants