Skip to content

Fix TypeScript 5.9.3 type errors in CI #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 23, 2025
Merged

Fix TypeScript 5.9.3 type errors in CI #30

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ba8fea
Initial plan
Copilot Oct 23, 2025
fb9840d
Fix TypeScript type errors in CI
Copilot Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ const DEFAULT_PERIOD = 30
* Generates a HMAC-based One Time Password (HOTP) using the provided secret and
* configuration options.
*
* @param {ArrayBuffer} secret - The secret used to generate the HOTP.
* @param {BufferSource} secret - The secret used to generate the HOTP.
* @param {Object} options - The configuration options for the HOTP.
* @param {number} [options.counter=0] - The counter value to use for the HOTP.
* Defaults to 0.
Expand Down Expand Up @@ -104,7 +104,7 @@ async function generateHOTP(
* configuration options.
*
* @param {string} otp - The OTP to verify.
* @param {ArrayBuffer} secret - The secret used to generate the HOTP.
* @param {BufferSource} secret - The secret used to generate the HOTP.
* @param {Object} options - The configuration options for the HOTP.
* @param {number} [options.counter=0] - The counter value to use for the HOTP.
* Defaults to 0.
Expand Down Expand Up @@ -256,7 +256,7 @@ export async function verifyTOTP({
return null
}

return verifyHOTP(otp, new Uint8Array(decodedSecret), {
return verifyHOTP(otp, decodedSecret, {
counter: getCounter(period),
digits,
window,
Expand All @@ -269,7 +269,7 @@ export async function verifyTOTP({
* Converts a number to a byte array.
*
* @param {number} num The number to convert to a byte array.
* @returns {Uint8Array} The byte array representation of the number.
* @returns {Uint8Array<ArrayBuffer>} The byte array representation of the number.
*/
function intToBytes(num) {
const arr = new Uint8Array(8)
Expand Down