Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 118: Check formula input #139

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Issue 118: Check formula input #139

merged 1 commit into from
Jul 9, 2024

Conversation

athowes
Copy link
Collaborator

@athowes athowes commented Jul 8, 2024 •
edited
Loading

Description

This PR closes #118.

I have checked the formula input is a formula and the variables are in the data. I used cli and added it to DESCRIPTION. I've also put the unit test for this back, which should pass now.

Checklist

  • My PR is based on a package issue and I have explicitly linked it.
  • I have included the target issue or issues in the PR title in the for Issue(s) issue-numbers: PR title
  • I have read the contribution guidelines.
  • I have tested my changes locally.
  • I have added or updated unit tests where necessary.
  • I have updated the documentation if required.
  • My code follows the established coding standards.
  • I have added a news item linked to this PR.
  • I have reviewed CI checks for this PR and addressed them as far as I am able.

@athowes athowes requested a review from seabbs July 8, 2024 12:59
@athowes
Copy link
Collaborator Author

athowes commented Jul 9, 2024

@seabbs similar to #137 -- if you're happy with this PR after review could we merge this please?

@athowes athowes added this pull request to the merge queue Jul 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 9, 2024
github-actions bot pushed a commit that referenced this pull request Jul 9, 2024
@athowes
Add formula input checking with cli (#139)
afc2d0f
@seabbs seabbs added this pull request to the merge queue Jul 9, 2024
Merged via the queue into main with commit ab14d49 Jul 9, 2024
9 checks passed
@seabbs seabbs deleted the check-formula branch July 9, 2024 13:01
seabbs pushed a commit that referenced this pull request Jan 10, 2025
@athowes
Add formula input checking with cli (#139)
3114433 
Former-commit-id: 778db866449dc515f0fad147367d4aca20da981a [formerly e7db1ce23e84f1f9926cf64c23c055ceb6ac5b04]
Former-commit-id: 09dbc351b1db6347cad598602561da4705da7aaa
seabbs pushed a commit that referenced this pull request Jan 21, 2025
@athowes
Add formula input checking with cli (#139)
f228a56 
Former-commit-id: ab14d49
Former-commit-id: bbefed5da432157d82156232d91f3b1faf480f35
seabbs pushed a commit that referenced this pull request Jan 21, 2025
@athowes
Add formula input checking with cli (#139)
7175370 
Former-commit-id: ab14d49
Former-commit-id: bbefed5da432157d82156232d91f3b1faf480f35
seabbs pushed a commit that referenced this pull request Jan 21, 2025
@athowes
Add formula input checking with cli (#139)
1734b39 
Former-commit-id: ab14d49
Former-commit-id: bbefed5da432157d82156232d91f3b1faf480f35
seabbs pushed a commit that referenced this pull request Jan 21, 2025
@athowes
Add formula input checking with cli (#139)
af420e3 
Former-commit-id: 778db866449dc515f0fad147367d4aca20da981a [formerly e7db1ce23e84f1f9926cf64c23c055ceb6ac5b04]
Former-commit-id: 09dbc351b1db6347cad598602561da4705da7aaa
seabbs pushed a commit that referenced this pull request Jan 21, 2025
@athowes
Add formula input checking with cli (#139)
a3208f3 
Former-commit-id: 778db866449dc515f0fad147367d4aca20da981a [formerly e7db1ce23e84f1f9926cf64c23c055ceb6ac5b04]
Former-commit-id: 09dbc351b1db6347cad598602561da4705da7aaa
Former-commit-id: af420e3
seabbs pushed a commit that referenced this pull request Jan 21, 2025
@athowes
Add formula input checking with cli (#139)
126cfda 
Former-commit-id: ab14d49
Former-commit-id: bbefed5da432157d82156232d91f3b1faf480f35
Former-commit-id: 1ff96dd4151b9d453b8b2865c62db2723729a313 [formerly 1734b39]
Former-commit-id: 2bf6ab46e94ef50d06786a2c3a711213c13ef494
seabbs pushed a commit that referenced this pull request Jan 21, 2025
@athowes
Add formula input checking with cli (#139)
13c1185 
Former-commit-id: ab14d49
Former-commit-id: bbefed5da432157d82156232d91f3b1faf480f35
Former-commit-id: 1ff96dd4151b9d453b8b2865c62db2723729a313 [formerly 1734b39]
Former-commit-id: 2bf6ab46e94ef50d06786a2c3a711213c13ef494
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seabbs seabbs seabbs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Checking formula input
2 participants
@athowes @seabbs