Skip to content

CG-5970: Cannot get accessToken #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Oct 25, 2023
Merged

CG-5970: Cannot get accessToken #40

merged 14 commits into from
Oct 25, 2023

Conversation

@jamestran1
Copy link
Contributor

@jamestran1 jamestran1 commented Oct 20, 2023 •
edited
Loading

CG-5970: Cannot get accessToken

Deployment:

To apply changes and make it visible to customers, there are two parts that need to be deployed:

  • MF backend: need to merge this PR and then trigger the GitHub action
  • MF frontend: go to Vercel and update the environment variable. The frontend will be deployed automatically once the PR is merged to the main branch

Changes

  • Add supported callback URL in MF backend.
  • Upgrade dependencies for MF backend.
  • Upgrade dependencies for MF frontend.
  • Remove redundant components.
  • Correct callback URL for EpiserverOIDCProvider.
  • Rotate AZURE_AD_CLIENT_SECRET for Azure AD in the local environment.

### Issue
There's one unresolved issue when building the source code:
image
The issue is resolved by change typescript-react-query to typescript-graphql-request

@vercel
Copy link

vercel bot commented Oct 20, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
musicfestival ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2023 10:40am

@jamestran1 jamestran1 marked this pull request as draft October 20, 2023 10:55
@jamestran1 jamestran1 marked this pull request as ready for review October 23, 2023 07:41
@jamestran1 jamestran1 self-assigned this Oct 23, 2023
@jamestran1 jamestran1 merged commit 82e5857 into main Oct 25, 2023
@jamestran1 jamestran1 deleted the fixbug/CG-5970-Cannot-get-access-token branch October 25, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cimdalli cimdalli cimdalli approved these changes

@jonasbergqvist jonasbergqvist Awaiting requested review from jonasbergqvist

@ThanhCN85 ThanhCN85 Awaiting requested review from ThanhCN85

Assignees

@jamestran1 jamestran1

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jamestran1 @cimdalli