Skip to content

Change sorting links in getPath #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 20, 2025
Merged

Change sorting links in getPath #177

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
924bc61
Change sorting links in getPath
exacs Nov 19, 2025
b1179d8
Reduce O(n2) compexity to O(n)
exacs Nov 19, 2025
375e32f
Write "support" lowercase
exacs Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 38 additions & 13 deletions packages/optimizely-cms-sdk/src/graph/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,11 @@ query GetPath($where: _ContentWhereInput, $locale: [Locales]) {
_Content(where: $where, locale: $locale) {
item {
_id
_metadata {
...on InstanceMetadata {
path
}
}
_link(type: PATH) {
_Page {
items {
Expand All @@ -70,6 +75,7 @@ query GetPath($where: _ContentWhereInput, $locale: [Locales]) {
locale
types
url {
base
hierarchical
default
}
Expand All @@ -86,6 +92,11 @@ query GetPath($where: _ContentWhereInput, $locale: [Locales]) {
_Content(where: $where, locale: $locale) {
item {
_id
_metadata {
...on InstanceMetadata {
path
}
}
_link(type: ITEMS) {
_Page {
items {
Expand All @@ -96,6 +107,7 @@ query GetPath($where: _ContentWhereInput, $locale: [Locales]) {
locale
types
url {
base
hierarchical
default
}
Expand All @@ -111,6 +123,9 @@ type GetLinksResponse = {
_Content: {
item: {
_id: string | null;
_metadata: {
path?: string[];
};
_link: {
_Page: {
items: Array<{
Expand All @@ -121,6 +136,7 @@ type GetLinksResponse = {
locale?: string;
types: string[];
url?: {
base?: string;
hierarchical?: string;
default?: string;
};
Expand Down Expand Up @@ -350,21 +366,30 @@ export class GraphClient {
return null;
}

const links = data?._Content?.item._link._Page.items;
const links = data._Content.item._link._Page.items;
const sortedKeys = data._Content.item._metadata.path;

// Return sorted by "hierarchical"
return links.toSorted((a, b) => {
const ha = a?._metadata?.url?.hierarchical ?? '';
const hb = b?._metadata?.url?.hierarchical ?? '';
if (!sortedKeys) {
// This is an error
throw new GraphResponseError(
'The `_metadata` does not contain any `path` field. Ensure that the path you requested is an actual page and not a block. If the problem persists, contact Optimizely support',
{
request: {
query: GET_PATH_QUERY,
variables: {
...pathFilter(path, options?.host),
...localeFilter(options?.locales),
},
},
}
);
}

if (ha > hb) {
return 1;
}
if (ha < hb) {
return -1;
}
return 0;
});
// Return sorted by the "sortedKeys"
const linkMap = new Map(links.map((link) => [link._metadata?.key, link]));
return sortedKeys
.map((key) => linkMap.get(key))
.filter((item) => item !== undefined);
}

/**
Expand Down