Skip to content

Conversation

@GiangNT95
Copy link
Contributor

Bug: CMS-47074

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@GiangNT95 GiangNT95 enabled auto-merge November 21, 2025 06:51
Copy link
Contributor

@exacs exacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change assumes that the image is squared (500x500) which may not be true.

The original issue (image stretched across full screen) seems to be a CSS issue because Next.js' <Image fill /> attribute requires container to have position: "relative", "fixed", "absolute".

Read more: https://nextjs.org/docs/pages/api-reference/components/image#fill

Copy link
Contributor

@exacs exacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should work.

Worth mentioning that, with this change, images will have always a 16/9 ratio because of width:100%; padding-top: 56.25%

@GiangNT95 GiangNT95 merged commit 09e7394 into main Nov 24, 2025
3 of 4 checks passed
@GiangNT95 GiangNT95 deleted the bugfix/CMS-47074-Exception-on-AboutUs-component-if-there-is-no-data-for-image-property branch November 24, 2025 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants