This repository was archived by the owner on Jun 13, 2023. It is now read-only.
feat(tornado_client.py): support tornado http client calls#318
Merged
feat(tornado_client.py): support tornado http client calls#318
Conversation
razlo
reviewed
Jan 13, 2021
razlo
left a comment
razlo
left a comment
There was a problem hiding this comment.
looks good overall
can you please add some UT? (even a sanity test)
| return wrapped(*args, **kwargs) | ||
|
|
||
| # Inject header to support tracing over HTTP requests | ||
| trace_id = uuid.uuid4().hex |
There was a problem hiding this comment.
I'd maybe export this header creation logic somewhere since we do it everywhere now
Contributor
Author
|
Added test @razlo |
razlo
previously approved these changes
Jan 13, 2021
razlo
approved these changes
Jan 13, 2021
Contributor
|
🎉 This PR is included in version 1.62.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.