This repository was archived by the owner on Jun 13, 2023. It is now read-only.
fix(aws lambda wrapper): allow exception without type#339
Merged
Conversation
ronyis
reviewed
Apr 26, 2021
| """ | ||
| self.error_code = ErrorCode.EXCEPTION | ||
| self.exception['type'] = type(exception).__name__ | ||
| if hasattr(exception, '__name__'): |
There was a problem hiding this comment.
Suggested change
| if hasattr(exception, '__name__'): | |
| if hasattr(type(exception), '__name__'): |
ronyis
reviewed
Apr 26, 2021
| if hasattr(exception, '__name__'): | ||
| self.exception['type'] = type(exception).__name__ | ||
| else: | ||
| self.exception['type'] = None |
There was a problem hiding this comment.
Suggested change
| self.exception['type'] = None | |
| self.exception['type'] = '' |
adavidai
changed the title
adavidai
changed the title
maorlx
approved these changes
Apr 27, 2021
Contributor
|
🎉 This PR is included in version 1.65.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.