fix(act): allow act API to be bindable to a context - e.g. REPL vs WebSocket/HTTP.

Change `act` API to be able to allow `newAct = api.act.bind(api, ctxt)` so a developer can
replace the `req, res` properties of `ctxt` in a REPL context - e.g. `ctxt.res.write = console.log`

BREAKING CHANGE: change `act(e, ctxt, cb)` to `act(ctxt, e)`

Author: bbartolome

lib/api/act.js

@@ -7,20 +7,20 @@
 'use strict';
 
 module.exports = function exported(_, async) {
-	return function act(pattern, context, done) {
+	return function act(context, pattern) {
 		var api = this;
 		var handlers = api.actions.list(pattern);
-		var callActions = _callActions.bind(
+		var callHandlers = _callHandlers.bind(
 			api,
-			pattern, context
+			context, pattern
 		);
-		var callback = done ? done : _.noop;
 
-		async.each(handlers, callActions, callback);
+		async.each(handlers, callHandlers);
 	};
 };
 
-function _callActions(pattern, context, handler, done) {
+function _callHandlers(context, pattern, handler, done) {
 	var api = this;
-	handler.call(api, pattern, context, done);
+
+	handler.call(api, context, pattern, done);
 }

test/test.api.js

@@ -18,20 +18,14 @@ test('api.act() with no callback', function(assert) {
 
 	// MOCKS
 	var mockActions = bloomrun();
-	mockActions.add(expectedPattern, function(args, ctxt, done) {
-		assert.deepEqual(args, expectedPattern);
+	mockActions.add(expectedPattern, function(ctxt, args, done) {
 		assert.deepEqual(ctxt, expectedContext);
+		assert.deepEqual(args, expectedPattern);
 		done();
 	});
 
-	var mockLodash = _.defaults({
-		noop: function() {
-			assert.pass();
-		}
-	}, _);
-
 	// TEST
-	var act = require('../lib/api/act.js')(mockLodash, async);
+	var act = require('../lib/api/act.js')(_, async);
 	var fixture = {
 		actions: mockActions,
 		act: act
@@ -41,38 +35,8 @@ test('api.act() with no callback', function(assert) {
 	// - the expected pattern; and,
 	// - the expected context
 	// assert that api.act() would call _.noop if no callback was provided
-	assert.plan(3);
-	fixture.act(expectedPattern, expectedContext);
-});
-
-test('api.act() with callback', function(assert) {
-	// EXPECTED
-	var expectedPattern = {
-		pattern: 1
-	};
-	var expectedContext = {
-		anon: true
-	};
-	var expectedError = 'expected error';
-
-	// MOCKS
-	var mockActions = bloomrun();
-	mockActions.add(expectedPattern, function(args, ctxt, done) {
-		done(expectedError);
-	});
-
-	// TEST
-	var act = require('../lib/api/act.js')(_, async);
-	var fixture = {
-		actions: mockActions,
-		act: act
-	};
-
-	// assert that api.act() would call the provided callback
-	assert.plan(1);
-	fixture.act(expectedPattern, expectedContext, function(err) {
-		assert.equal(err, expectedError);
-	});
+	assert.plan(2);
+	fixture.act(expectedContext, expectedPattern);
 });
 
 // api.view() -------------------------------------

test/test.index.js

@@ -45,21 +45,19 @@ test('register() an action and act() on it', function(t) {
 	};
 	var testContext = 'some arbitrary context object';
 
-	t.plan(3);
+	t.plan(2);
 	api.register({actions: [
 		{
 			name: 'test action',
 			pattern: testPattern,
-			handler: function(args, context, done) {
-				t.equal(args, testPattern);
+			handler: function(context, args, done) {
 				t.equal(context, testContext);
+				t.equal(args, testPattern);
 				done();
 			}
 		}
 	]}, function() {
-		api.act(testPattern, testContext, function() {
-			t.pass('passed handler callback');
-		});
+		api.act(testContext, testPattern);
 	});
 });