Skip to content

Fix misleading comments #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cedricfrancoys merged 1 commit into from
Oct 27, 2024
Merged

Fix misleading comments #195

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/equal/cron/Scheduler.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ private static function computeAvailableMemory() {
* Non-recurring tasks are deleted once they've been run.
* #memo - The Scheduler service always operates as root user.
*
* @param int[] $tasks_ids Optional array of identifiers of specific tasks to run.
* @param int[] $tasks_ids (optional) Array of identifiers of specific tasks to run.
*
*/
public function run($tasks_ids=[]) {
Expand Down Expand Up @@ -165,7 +165,7 @@ public function run($tasks_ids=[]) {
* @param string $name Name of the task to schedule, to ease task identification.
* @param integer $moment Timestamp of the moment of the first execution.
* @param string $controller Controller to invoke, with package notation.
* @param string $params JSON string holding the payload to relay to the controller.
* @param array $params The params associative array to relay to the controller.
* @param boolean $recurring Flag to mark the task as recurring.
*/
public function schedule($name, $moment, $controller, $params, $recurring=false, $repeat_axis='day', $repeat_step='1') {
Expand Down
7 changes: 3 additions & 4 deletions lib/equal/data/DataGenerator.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@
class DataGenerator {

/**
* @param string $field Field name.
* @param string $field_descriptor Field descriptor.
* @param string $lang Lang code of the language in which the value must be generated (for multilang fields).
* @param string $field Field name.
* @param array $field_descriptor Field descriptor.
* @param string|null $lang Lang code of the language in which the value must be generated (for multilang fields).
* @return array|bool|float|int|mixed|string|null
*/
public static function generateFromField(string $field, array $field_descriptor, string $lang = null) {
Expand Down Expand Up @@ -882,5 +882,4 @@ public static function address($lang = null): string {
self::addressCountry($lang)
);
}

}