fix: handle Anthropic thinking blocks to prevent 400 errors #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add proper handling of thinking blocks in non-stream translation - Filter and combine thinking blocks with text blocks for OpenAI compatibility - Update mapContent function to handle thinking blocks in both string and ContentPart formats - Add comprehensive tests for thinking blocks with and without tool calls - Since GitHub Copilot doesn't support thinking blocks natively, merge thinking content with text Fixes ericc-ch#61
lanej
force-pushed
the
feat/thinking-blocks-support
branch
from
6ec3edd to
0d3c786
Compare
lanej
changed the title
The .loose() method doesn't exist in Zod - replace with .passthrough() to allow additional properties in the anthropicStreamEventSchema. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Since thinking blocks are an Anthropic-specific feature, the tests should use an Anthropic model instead of gpt-4o for accuracy and clarity. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Owner
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes 400 Bad Request errors that occur when Anthropic thinking blocks are present in messages. Without this fix, thinking blocks are either filtered out or ignored during translation, resulting in incomplete or malformed content being sent to the OpenAI API.
Changes
Test plan
bun testFixes #61
🤖 Generated with Claude Code