Skip to content

Conversation

@evrimfeyyaz
Copy link
Contributor

As per our conversation in #542.

@codecov
Copy link

codecov bot commented May 3, 2020

Codecov Report

Merging #544 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #544   +/-   ##
=======================================
  Coverage   99.54%   99.54%           
=======================================
  Files          45       45           
  Lines         662      662           
  Branches      135      135           
=======================================
  Hits          659      659           
  Misses          3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c2ec4e...bd3c2e8. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.547% when pulling bd3c2e8 on evrimfeyyaz:master into 3c2ec4e on ericgio:master.

@ericgio ericgio changed the base branch from master to 5.x May 16, 2020 20:35
@ericgio ericgio merged commit 54ad584 into ericgio:5.x May 16, 2020
@ericgio
Copy link
Owner

ericgio commented May 16, 2020

@evrimfeyyaz: thanks for submitting this PR! I'm sorry it's taken me so long to get to it. Looks great to me. After more consideration, I think this is potentially a breaking change for some people, so I'd prefer to release it as part of v5.0 rather than v4.0. I've gone ahead and merged your changes into the 5.x branch. Thanks again for contributing!

@evrimfeyyaz
Copy link
Contributor Author

@ericgio Happy to be of help, thanks for this great component!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants