Update AsyncExample.js #578
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
filterBy={() => true}to theAyncExample.It's an issue when the server is filtering by multiple fields (such as name, family-name, email, tags, etc..)
and then, if the client
labelKeyis only byname(for example), no result will be shown.Ones can set the
labelKeyto have all the fields inside or createfilterByarray on all the fields (which is not always possible, and sometimes even the backend doesn't return all the fields to the client).Also, when filtering server-side, it's a waste to filter again in client-side all results.
IMHO It's important thing to be in the example, as in our case, took us few hours to find this out and we unfortunately first tried to set the
labelKeyto${name} ${email}and then override bothrenderInput,renderTokenandrenderMenuItemChildrento show only thenamefield...