fix: remove @emotion/core types after running yarn #705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a known issue with storybook that the @emotion/core dependency augments the React `HTMLAttributes` with an additional `css` property. This causes the compiled types of react-bootstrap-typeahead to include that attribute as well, which in turns breaks Typescript compilation of projects using it. See: emotion-js/emotion#1257 (comment)
|
Thanks @DASPRiD! |
|
Released as part of v6.0.0-alpha.10 |
I think you might not have run |
|
@DASPRiD where are you seeing the declarations show up? Are they actually output in the package files or just implicitly pulled in and applied when typechecking your code? Thanks. |
|
Looks like I needed to |
|
@ericgio That was it, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a known issue with storybook that the @emotion/core dependency augments the React
HTMLAttributeswith an additionalcssproperty. This causes the compiled types of react-bootstrap-typeahead to include that attribute as well, which in turns breaks Typescript compilation of projects using it.See: emotion-js/emotion#1257 (comment)
If possible, please release this in an alpha.10 package soon, as it is currently stopping one of our projects from building.