Skip to content

Add sync stages diagnostic script #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
May 15, 2023
Merged

Add sync stages diagnostic script #13

merged 16 commits into from
May 15, 2023

Conversation

acuderman
Copy link
Contributor

@acuderman acuderman commented May 10, 2023 •
edited
Loading

What is this PR for?

  • Adds syncs stage section to the diagnostics service which fetches status from a remote database "chaindata" (table "SyncStage"). Data is decoded to utf-8 / number and shown in the table
  • DB path extraction logic was moved in order to reuse it in multiple handlers
  • "fetch" method moved to a separate struct (together with some added remote API-related helper methods)
  • Tests added for the newly added code (and some of the existing functions)

Andraz Cuderman and others added 16 commits May 10, 2023 18:44
@acuderman
Add fetch stage sync progress support
abd809e 
Signed-off-by: Andraz Cuderman <cuderman.andraz@gmail.com>
@acuderman
Reuse db full name extraction logic
a12b32f 
Signed-off-by: Andraz Cuderman <cuderman.andraz@gmail.com>
@acuderman
Add readme about sync stages
d285892 
Signed-off-by: Andraz Cuderman <cuderman.andraz@gmail.com>
@acuderman
Remove trailing space
d4189e5 
Signed-off-by: Andraz Cuderman <cuderman.andraz@gmail.com>
@acuderman
Move strings to constants
d63fbfa 
Signed-off-by: Andraz Cuderman <cuderman.andraz@gmail.com>
@acuderman
Fix README typos
0c22269 
Signed-off-by: Andraz Cuderman <cuderman.andraz@gmail.com>
@acuderman
Use dependency injection for remote cursor
90c7bdf
@acuderman
Remote private setters
ec01f76
@acuderman
Add tests for sync stages handler
ebabc19
@acuderman
Improve unmarshall func name
ec3e37e
@acuderman
Remove redundant info in function name
d27a825
@acuderman
Add remote db init tests
6903aa8
@acuderman
Move api access logic to separate struct
7778a97
@acuderman
Rename api result helper function
cd88b2f
@acuderman
Improve error messages
e7b4f6f
@acuderman
Fix typos
82dfafc
@acuderman acuderman marked this pull request as ready for review May 13, 2023 07:51
@AlexeyAkhunov
Copy link
Contributor

Great PR, thank you, will check further and merge soon, and contact you

@AlexeyAkhunov AlexeyAkhunov merged commit 7fe89fd into erigontech:main May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@acuderman @AlexeyAkhunov