Fix ComboBox focus steal in plan viewer + DOP 2 skew threshold#508
Merged
erikdarlingdata merged 1 commit intodevfrom Mar 10, 2026
Merged
Fix ComboBox focus steal in plan viewer + DOP 2 skew threshold#508erikdarlingdata merged 1 commit intodevfrom
erikdarlingdata merged 1 commit intodevfrom
Conversation
ComboBox statement selector (#507): - PreviewMouseDown was stealing focus from ComboBox dropdown items, preventing statement selection in multi-statement plans - Dropdown items live in a separate Popup visual tree, so the existing FindVisualParent<ComboBox> guard couldn't find the parent - Added ComboBoxItem checks to both Dashboard and Lite - Also added missing DataGrid guard to Lite (Dashboard already had it) Parallel skew rule (#73, synced from PerformanceStudio): - Filter out thread 0 (coordinator) from skew calculation - Raise DOP 2 threshold from 75% to 80% Fixes #507. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
erikdarlingdata
added a commit
that referenced
this pull request
Mar 10, 2026
- Port MethodProfiler and QueryLogger from Dashboard to Lite for identifying slow methods and DuckDB queries (500ms threshold, daily rotating logs with 7-day cleanup) - Add 5-minute server inventory cache to both Dashboard and Lite to eliminate 12s repeat loads on FinOps tab revisits - Parallelize LoadPerServerDataAsync (4 sub-loads) and LoadUtilizationAsync (4 inner queries) with Task.WhenAll in both Dashboard and Lite - Add query timing instrumentation to 7 LocalDataService methods - Fix Plan Viewer PreviewMouseDown stealing focus from ComboBox and DataGrid in Dashboard (complements Lite fix from #508) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ComboBox statement selector (fixes #507):
PreviewMouseDownwas callingFocus()which stole focus from ComboBox dropdown items, preventing statement selection in multi-statement plansFindVisualParent<ComboBox>couldn't walk back to the parentComboBoxItemandFindVisualParent<ComboBoxItem>checks to both Dashboard and LiteFindVisualParent<DataGrid>guard to Lite (Dashboard already had it)Parallel skew Rule 8 (synced from PerformanceStudio #73):
Test plan
🤖 Generated with Claude Code