Merged
Conversation
43081j
approved these changes
Jul 27, 2024
Contributor
|
makes sense to me 👍 |
Contributor
Author
|
@43081j It looks like this got stripped out of the https://www.runpkg.com/?module-replacements@2.3.0/package.json |
Contributor
|
good catch. this is because tshy generates the export map for us, so we should've actually added it to the tshy config rather than directly to the map have opened #131 to fix |
Contributor
Author
|
Gotcha. Sorry, was not/am not familiar with tshy, I assumed I could just add it directly to the export map (did it from the web interface IIRC, didn't even pull locally) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the manifests to the export map so they can be accessed by tools that utilize Node's module resolution. For example, if you tried to run this:
You'd see this:
Also adds
package.jsonto the exports map too -- it's a handy thing that many other libraries offer. Never know, someone might want to access it in a script for some reason.