Correct the reproducibility of quantum weight reduction #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
I thought something in the tutorial would need changing. It does not, everything still works as before from the tutorial. Ready to merge. |
esabo
requested changes
Jul 24, 2024
src/Quantum/weight_reduction.jl
Outdated
| else # keep the cycle as is | ||
| push!(Bim1[i], c[j]) | ||
| end | ||
| hx = Int.(data.(H_X)) |
Owner
There was a problem hiding this comment.
data. is no longer compatible with the new version of Oscar. Let's use the provided _Flint...() methods
Collaborator
Author
There was a problem hiding this comment.
latest commit brings in the _Flint... methods from the dev branch and uses them.
esabo
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't merge yet. Putting this PR here so that this is visible.
Everything is actually reproducible now by passing around an RNG object and explicitly using it.
To do: