-
Notifications
You must be signed in to change notification settings - Fork 11
fix documentation errors in build and add ECC Zoo links for product codes #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Please don't merge this yet. I am waiting the results from the build. |
|
I think this is ready for review. I had added the ECC Zoo links for product codes as well. For the false positives errors mentioned in #40 (comment), I will look into it later. Thank you! |
|
I'll just review it when the false positives are done because it won't compile before then anyway. |
|
Woohoo, documentation build passed. There is a way to suppress the errors using I think this is ready for review, Thank you! |
|
There are a lot of deletions but I don't see things added back in? |
|
For some methods, docstrings are not defined, so called them in docs gives error. Namely: |
|
Thanks for your comment! I hope this is okay. There are no png images in assets as that was causing the documentation error in This PR make sure that we can deploy the docs by suppressing all the errors for methods for which docstrings are not defined! I think it's ready for review, Thank you! P.S I used |
I noticed there was some errors with build. For the latest documentation to be deployed, all these errors needed to be fixed. The above two errors were causes by the references. I have updated them.
I will also fix all the others errors so that the build passes.