-
Notifications
You must be signed in to change notification settings - Fork 11
Coprime Bivariate Bicycle Codes via Univariate Polynomial Ring #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@esabo, I think the PR is ready for review. Thanks for your feedback. |
4053d14 to
6c98047
Compare
|
@esabo, Thank you for your comments. All the tests now pass for these codes. The documentation error is unrelated to this PR. Please do check these codes by running the tests on your end as well. P.S. The |
This PR aims to introduce
Coprime Bivariate Bicyclecodes via Univariate Polynomial Ring from https://arxiv.org/pdf/2408.10001v1.There were no quotient_ring
quomethod forunivariatepolynomial ring usingidealso I definedMpPolyRingin one variable. Please see the test-cases. Thenvalues fromTable 2are correct but there is some discrepency in thekvalues. So, there is some error in the code, but I think that can be fixed.I think you would like to make some changes to this implementation so that conventions with other codes are followed. Maybe we can use
residue_ringinstead ofquosince we are considering univariate polynomial rings. Pardon, if I missed something or the current form is not that according to requirement.Maybe I should use this structure instead?
I think coceptually, there is not much that needs to be changed, It's mostly the
BivaraiteBicycleCodewith some more freedom in the input. It's just using one Univariate Polynomial ringπ = xy.BivaraiteBicycleCodehas some restrictions that like Polynomials had to be 2 variables, and also you are collectinglandmfromcollect(exponents(h))but in univariate case, it's not a 2D vector as well, so we can't doexps[1][2]for example. That's why I defined a new method,CoPrimeiBivariateBicycleCodewhich gives correct n values from Table 2 of aforementioned paper. I hope can be fixed to give correctkvalues. I think I have messed up some small detail somewhere, that might be reason for k values discrepency.Miscellaneous detail: The current dev version had some errors.
GroupAlgebraElemnot defined if you run the dev version locally. So, I had to doPkg.resolve(), Pkg.update()to addHeckeas these are found there.