Support Elixir v1.13 #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In version >= 1.13 some expressions previously without a line now have a line propagated from a parent. This line does not always match the location of the expression in the code. So we still need to look at the tokens to correct these locations. This location presence required small changes in the AstSpecifier code because now we can't be sure when the expression has a line then this line is correct. Changes: - Adapt debug.ex to new elixir api - Add specifying a line in nil. - Propagate a generated flag from clauses to conditions. - Consume the beginning token of list or tuple. - Stop predicting the last line of the form from :bin or :cons expressions.
Premwoik
force-pushed
the
support-elixir-v1.13
branch
from
e70fdd8 to
33bd901
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #28. It also fixes some abnormalities regarding token usage.