Skip to content

Conversation

@Premwoik
Copy link
Collaborator

@Premwoik Premwoik commented Feb 21, 2022

This PR addresses #42 and adds missing pp for a remote name that is used by the call_intersect error formatter.

I also added a test case that confronts pp_expr with the sent example from the issue. The produced result is not fully correct and it needs further investigation.

I don't know why one fmt test won't work on CI when works locally:

code: res = ElixirFmt.format_error(error, [])
     stacktrace:
       :erlang.++("(non_error_kind(), payload, stacktrace() -> payload)", [])
       (gradualizer 0.0.0+build.1009.ref650998d) /home/runner/work/gradient/gradient/deps/gradualizer/src/gradualizer_fmt.erl:505: :gradualizer_fmt.pp_intersection_type/2

@erszcz
Copy link
Contributor

erszcz commented Feb 22, 2022

I don't know why one fmt test won't work on CI when works locally

Hmm, interesting, I'll take a closer look at it, but will leave the PR open in the meantime.

@Premwoik Premwoik linked an issue Feb 23, 2022 that may be closed by this pull request
@erszcz
Copy link
Contributor

erszcz commented Mar 2, 2022

@Premwoik I see the CI passes now. Is there anything else left to do in this PR?

@Premwoik
Copy link
Collaborator Author

Premwoik commented Mar 2, 2022

@Premwoik I see the CI passes now. Is there anything else left to do in this PR?

I think that the main goal is completed, and we can merge.

@erszcz erszcz merged commit 080a6bd into main Mar 2, 2022
@erszcz erszcz deleted the fix-pp-remote-name branch March 2, 2022 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing pretty printing elixir expression for remote Exception

3 participants