Support nested modules #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks good 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one refers to #11. It turned out that support for nested modules was just provided. Elixir nested modules are separate beam files with the name
Elixir.ParentModule.NestedModule, so they can be handled as normal modules. The tokens lookup is restricted to the location of the current specified function, so it is not possible to mistake tokens between modules.This PR adds a test to ensure that everything works as it should. By the way, I move the logic that loads tokens to the file utils module and reused it in tests. Now it is possible to specify abstract forms even when tokens cannot be loaded.