-
Notifications
You must be signed in to change notification settings - Fork 13
Update TypedServer demo #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@zuiderkwast This is the example code from the Friday live demo. To make it work the way it does (looking from the utility / UX perspective) josefs/Gradualizer#391 is necessary upstream. I didn't see any breakage in Gradualizer from incorporating that change, but OTOH I'm not yet done with all the relevant literature on the subject, which could highlight potential issues. Just letting you know what my thinking currently is. |
Premwoik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Well done examples :D Thanks for adding the formatter of the nonexhaustive error :)
| end | ||
|
|
||
| @impl true | ||
| # @impl true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why comment out this here and in the other places?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This only makes sense if use GenServer is also enabled at the top, but this in turn leads to a type error reported within GenServer implementation. I don't want this to clutter the output when demoing, but ultimately we would want these uncommented and the error sorted out.
Good point, though, I'll create a ticket to track this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tracked as #64
Thanks for inviting me to the presentation! It was very good! About the PR, I'm convinced now. :) |
This PR updates the TypedServer demo to use current Gradient (instead of GradualizerEx) and makes sure it's runnable as is without any glitches.
The demo as of this PR still relies on two non-standard features in upstream Gradualizer:
The aim is to get rid of any customisations and either make the demo conform to the upstream feature set or merge the necessary changes upstream.