Skip to content

Conversation

@erszcz
Copy link
Contributor

@erszcz erszcz commented Mar 21, 2022

This PR updates the TypedServer demo to use current Gradient (instead of GradualizerEx) and makes sure it's runnable as is without any glitches.

The demo as of this PR still relies on two non-standard features in upstream Gradualizer:

The aim is to get rid of any customisations and either make the demo conform to the upstream feature set or merge the necessary changes upstream.

@erszcz erszcz requested a review from Premwoik March 21, 2022 11:00
@erszcz
Copy link
Contributor Author

erszcz commented Mar 21, 2022

@zuiderkwast This is the example code from the Friday live demo. To make it work the way it does (looking from the utility / UX perspective) josefs/Gradualizer#391 is necessary upstream. I didn't see any breakage in Gradualizer from incorporating that change, but OTOH I'm not yet done with all the relevant literature on the subject, which could highlight potential issues. Just letting you know what my thinking currently is.

Copy link
Collaborator

@Premwoik Premwoik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Well done examples :D Thanks for adding the formatter of the nonexhaustive error :)

end

@impl true
# @impl true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why comment out this here and in the other places?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only makes sense if use GenServer is also enabled at the top, but this in turn leads to a type error reported within GenServer implementation. I don't want this to clutter the output when demoing, but ultimately we would want these uncommented and the error sorted out.

Good point, though, I'll create a ticket to track this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tracked as #64

@erszcz erszcz merged commit 370c895 into main Mar 21, 2022
@erszcz erszcz deleted the update-typed-gen-server-demo branch March 21, 2022 13:23
@zuiderkwast
Copy link

@zuiderkwast This is the example code from the Friday live demo. To make it work the way it does (looking the from the utility / UX perspective) josefs/Gradualizer#391 is necessary upstream.

Thanks for inviting me to the presentation! It was very good! About the PR, I'm convinced now. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants