Skip to content

Conversation

@Premwoik
Copy link
Collaborator

@Premwoik Premwoik commented Mar 30, 2022

This PR focused on adjusting tests to pass on Elixir 1.11 and 1.13 with OTP 24. As a result, I enabled versions 1.11 and 1.13 in CI. The changes were mainly in making expected values flexible enough to match with results produced by each version.

Supported Elixir versions

  • 1.11
  • 1.12
  • 1.13

Testing examples compilation

It is possible now to not compile the latest feature examples on the older versions. It can be requested by placing the .ex file in the 1.12/ or 1.13/ directory (It means that at least version x.xx is required to compile this file).

Skipping tests not for the current version

The tags were introduced to allow excluding tests not supporting the current Elixir version.

Available tags

  • ex_gt_* - testcase require version grater than * (e.x. ex_gt_1_12)
  • ex_lt_* - testcase require version lower than * (e.x. ex_lt_1_12)

@Premwoik Premwoik force-pushed the enable-elixir-11-and-13-in-ci branch from 817f2a3 to 9f8f44a Compare March 31, 2022 07:55
@Premwoik Premwoik force-pushed the enable-elixir-11-and-13-in-ci branch 2 times, most recently from 44823d2 to 4b31910 Compare March 31, 2022 12:18
@Premwoik Premwoik force-pushed the enable-elixir-11-and-13-in-ci branch from 4b31910 to 7be307d Compare March 31, 2022 12:48
@Premwoik Premwoik linked an issue Mar 31, 2022 that may be closed by this pull request
@Premwoik Premwoik marked this pull request as ready for review March 31, 2022 12:49
@Premwoik Premwoik requested a review from erszcz March 31, 2022 12:49
Copy link
Contributor

@erszcz erszcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Awesome job 🎉

@Premwoik Premwoik merged commit efd00e9 into main Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Check what effort it would be to reenable Elixir 1.11 in CI

3 participants