Skip to content

Conversation

@lumirlumir
Copy link
Member

@lumirlumir lumirlumir commented Nov 17, 2025

Prerequisites checklist

What is the purpose of this pull request?

In this PR, I've fixed a CI failure caused by the newly updated baseline.

In PR #326, the color-mix function's baseline was changed, which caused CI to fail:

image

https://github.com/eslint/css/actions/runs/19428945309/job/55582966958

image

Oddly, this CI failure wasn't detected in #326 itself because the test workflow didn't run in the auto-generated PR:

image

What changes did you make? (Give an overview)

In this PR, I've fixed a CI failure caused by the newly updated baseline.

I've replaced the color-mix function with the light-dark function to preserve the test case's original intent as much as possible.

Related Issues

Ref: #326

Is there anything you'd like reviewers to focus on?

Looking through the auto-generated PRs in the history, it seems that none of them run the test workflow. They only run the following three cases:

image

I think we need to update some setup so the CI workflow can run on auto-generated PRs. However, I'm not sure what the best approach is, since this may not be fixable at the code level and might require changes to the GitHub repository settings.

FYI, auto-generated release-please PRs, as well as repositories containing Markdown, CSS, JSON, and others, are also affected.

@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Nov 17, 2025
@lumirlumir lumirlumir marked this pull request as ready for review November 17, 2025 14:33
@lumirlumir lumirlumir requested a review from a team November 17, 2025 14:40
Copy link
Member

@fasttime fasttime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fasttime fasttime added the accepted There is consensus among the team that this change meets the criteria for inclusion label Nov 17, 2025
@fasttime fasttime merged commit 3a0992e into main Nov 17, 2025
23 checks passed
@fasttime fasttime deleted the test-fix-ci-failure branch November 17, 2025 16:12
@github-project-automation github-project-automation bot moved this from Needs Triage to Complete in Triage Nov 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

accepted There is consensus among the team that this change meets the criteria for inclusion chore

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

3 participants