How to .defineRule in ESLint class?

[fisker]

When use ESLint class like this

new ESLint({plugins: {foo}}).lintFiles('.')

The result message missing ruleId.

There was .defineRule in Linter class, how do I give a rule name in ESLint class? Or shouldn't it use id from foo.rules?

[fisker]

I guess I made a mistake, it worked

eslint/tests/lib/eslint/eslint.js

Line 2125 in c6ee180

assert.strictEqual(results[0].messages[0].ruleId, "test/example-rule");

. Will dig deeper.

[mdjermanovic]

There was .defineRule in Linter class, how do I give a rule name in ESLint class? Or shouldn't it use id from foo.rules?

It's using id from foo.rules. You're probably missing plugins: ["foo"] in the config. Top level plugins is to pass preloaded plugin implementations, config.plugins is to specify which plugins should be used.

For example:

new ESLint({
    plugins: {
        foo
    },
    baseConfig: {
        rules: {
            "foo/my-rule": 2
        },
        plugins: ["foo"] // <--
    }
});

[fisker]

No, my real problem is my rule fix to invalid code, then eslint parse the output again, but in the fatal message there is no ruleId, I thought it's missing. As I understand ESLint will merge fixes before the next round of running, so I don't think ESLint can trace which rule cause the broken fix? Context sindresorhus/eslint-plugin-unicorn#1906 (comment)

[mdjermanovic]

That's correct. ESLint applies all fixes from all rules and then runs another round of parsing, linting, and fixing. If there is a parsing error in the fixed code, ESLint doesn't trace which rule has caused it, as it doesn't parse code after each individual fix.

[fisker]

Thank you for the information.