docs: [class-methods-use-this] explain purpose of rule #20008
Conversation
✅ Deploy Preview for docs-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
lumirlumir
added
the
accepted
Co-authored-by: Nicholas C. Zakas <nicholas@humanwhocodes.com>
JoshuaKGoldberg
left a comment
JoshuaKGoldberg
left a comment
There was a problem hiding this comment.
Looking good! I quite like the overall flow of this page - it's much cleaner and clearer now. Very nice. 🔥
I just have a few requests to clean up bits of flow and phrasing. Nothing major that I would cling to strongly. But I do think they'll help. WDYT?
|
@kirkwaiblinger There seem to be some comments that need your attention. |
Thanks for the ping. I have been busy but expect to get to this within the upcoming week. Cheers! |
Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
|
/easycla |
|
@kirkwaiblinger can you clean this up so we can merge? |
lumirlumir
left a comment
lumirlumir
left a comment
There was a problem hiding this comment.
LGTM, thanks!
Would like @nzakas and @JoshuaKGoldberg to verify before merging.
JoshuaKGoldberg
left a comment
JoshuaKGoldberg
left a comment
There was a problem hiding this comment.
Great! Deferring to @nzakas as the remaining review.
github-project-automation
bot
moved this from Second Review Needed
to Complete
in Triage
5 participants
Prerequisites checklist
What is the purpose of this pull request? (put an "X" next to an item)
[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofix to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:
fixes #19852
What changes did you make? (Give an overview)
docs
Is there anything you'd like reviewers to focus on?
cc @JoshuaKGoldberg